Unsub backoff spec changes #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
//CC @Menduist |
|
@AgeManning do you have some time to give this pull request a review? |
AgeManning
reviewed
Jan 13, 2022
protocols/gossipsub/src/behaviour.rs
Outdated
| @@ -1092,10 +1093,15 @@ where | |||
| self.backoffs | |||
There was a problem hiding this comment.
Shouldn't we be updating our local store also, as well as telling the peer what the backoff time should be?
There was a problem hiding this comment.
I added a test that should check if the used and sent backoff are the unsubscribe backoff
divagant-martian
force-pushed
the
unsub-backoff
branch
from
09f6a16
to
497e056
Compare
|
@mxinden could you give CI a check? Not sure if related to the latest rust release, but it works on my machine. I tried clearing the cache too, still works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the changes specified by libp2p/specs#383 (to my best understanding)